Boshen
Boshen
Took another look at this. Nova engine should report its own syntax errors if oxc doesn't report them from `oxc_parser`, as they require tracking context (such as strict mode).
> ## [CodSpeed Performance Report](https://codspeed.io/oxc-project/oxc/branches/09-15-feat_ast_add_a_dummy_node_id_field_to_all_visitable_ast_types) > ### Merging oxc-project/oxc#5775 will **degrade performances by 3.87%** > Comparing `09-15-feat_ast_add_a_dummy_node_id_field_to_all_visitable_ast_types` ([00ce823](https://github.com/oxc-project/oxc/commit/00ce823767ee95ec84dd481577845f01d5877c3c)) with `09-15-fix_ast_tools_fix_miscalculation_of_enum_layouts` ([ea1c733](https://github.com/oxc-project/oxc/commit/ea1c733b844a16b4b5755d66420a6fc73d17d428)) > > ### Summary > `❌ 3` regressions `✅...
> A few places are creating these nodes without AstBuilder; For now I've assigned them directly but should be taken care of as part of making types non_exhaustive. I cleaned...
Close as stale. Feel free to revive this.
@camc314 can you help and get this PR merged.
### Merge activity * **Nov 9, 4:16 AM EST**: The merge label '0-merge' was detected. This PR will be added to the [Graphite merge queue](https://app.graphite.dev/merges?org=oxc-project&repo=oxc) once it meets the requirements....
Plugin-legacy does not strictly require this, we have a draft PR https://github.com/vitejs/rolldown-vite/pull/80
The leaks: https://github.com/rolldown/rolldown/blob/df7c907db3c9dd9a07e2311573eb9b1def2e0631/crates/rolldown_binding/src/options/plugin/js_plugin.rs#L482 https://github.com/rolldown/rolldown/blob/df7c907db3c9dd9a07e2311573eb9b1def2e0631/crates/rolldown_binding/src/options/plugin/js_plugin.rs#L509 How I found `OutputChunk`: Using https://docs.rs/dhat/latest/dhat/, add ``` #[global_allocator] static ALLOC: dhat::Alloc = dhat::Alloc; ``` to `crates/rolldown/src/lib.rs` add `profiler: Option` to `Bundler` in `crates/rolldown/src/bundler.rs`. Add `self.profiler...
I tried `Weak` in https://github.com/rolldown/rolldown/tree/09-26-fix_rolldown_binding_use_weak_outputchunk_to_prevent_memory_leak It seems to be working after I cleared more data during `Bundler::close`.
Given ```js const result = await rolldown.build({}); ``` Previous proposal will cause result to be undefined. Your proposal changes it to ```js const result = await rolldown.build({}); // safe to...