Boshen

Results 565 comments of Boshen

We already have https://github.com/oxc-project/oxc/blob/aeda84f904a6d4ea001bfa021752e64283fc56c4/crates/oxc_transformer/src/es2018/object_rest_spread/object_spread.rs#L83 which breaks `monitor-oxc` 🤣 ``` /home/runner/work/monitor-oxc/monitor-oxc/node_modules/.pnpm/@[email protected]/node_modules/@aws-sdk/client-cognito-identity/dist-cjs/index.js:795 var _CreateIdentityPoolCommand = class _CreateIdentityPoolCommand extends (import_smithy_client.Command.classBuilder().ep(babelHelpers.objectSpread2({}, commonParams)).m(function(Command, cs, config, o) { ^ ReferenceError: babelHelpers is not defined ```

Converted to draft. Please let us know when PR is ready for review.

We address import order properly in the formatter.

We are prototyping dts transform with `--isolatedDeclarations` in oxc, stay tuned. But you still need another plugin if you want normal dts emit :-(

Caused by https://github.com/oxc-project/oxc/blob/0a33e2792f23effe51bf13e955de14a8c9a0b9c6/crates/oxc_semantic/src/binder.rs#L160 Stack trace: ``` thread '' panicked at /Users/boshen/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/oxc_index-3.0.0/src/indexing.rs:38:10: index out of bounds: the len is 2 but the index is 4294967294 stack backtrace: 0: _rust_begin_unwind 1: core::panicking::panic_fmt...

This is not a good first issue yet.

> Can we add CJS to this list too? I need this for oxc-jest. CJS is in the milestone https://github.com/oxc-project/oxc/milestone/6

The list is not that bad actually, we end up with a few groups: * regex features - transform to regex constructor * class stuff - `ClassXXX` * syntax sugars...

We should add https://ast-grep.github.io/catalog/rust/#beware-of-char-offset-when-iterate-over-a-string