Boshen
Boshen
There is no rush! Sorry I didn't invest enough time to understand the full context, twitter sometimes gets into me and I just rushed things :-(
> Should I discard it in favor of detecting facade modules? I think so, I want to have Shopify use more oxlint rules so it can eventually drop eslint for...
Found a better representation https://twitter.com/boshen_c/status/1790353605234655637 
In what stages does esbuild and rollup do this? These features should be builtin features provided by oxc. Oxc already has a work-in-proess transformer and minimizer, ideally we just have...
This is why I am interested in how esbuild and rollup solves these problems, even it's inside a plugin.
I think I can figure this out if we reduce the scope to inlining `process.env.x` and identifiers, as shown in https://github.com/swc-project/swc/blob/94da1241720ed029bc41b6068a9267e2c86347d0/crates/swc_ecma_transforms_optimization/src/inline_globals.rs
@hyf0 Can you give me test case in Rolldown so I can test the whole thing end to end?
> @Boshen can we please update this? Feel free to edit it, you have permission to do so.
https://github.com/rolldown/rolldown/blob/d1a40861b2632acd386c6cb48330df8bc593c0f5/packages/rolldown/rolldown.config.mjs#L41-L45
Skeleton is done in https://github.com/oxc-project/oxc/pull/3803, I'll port esbuild's behaviour and tests.