Boshen

Results 565 comments of Boshen

This rule is pretty complicated, let's see whether @rzvxa can help. Feel free to ask questions.

The requirement for `ast_node_id` has been brought up a couple times in the past, I think it's worthy to create a separate issue, bike-shed it and then implement it.

Are we able to provide a cached fs in `LintContext`?

It seems like we don't need the resolver, we just need to walk the directories and cache the found files ...

Good call, this is a missing feature.

Next version: - `--disable-react-plugin` — Disable react plugin, which is turned on by default - `--disable-unicorn-plugin` — Disable unicorn plugin, which is turned on by default - `--disable-typescript-plugin` — Disable...

Changing a diagnostic to an error was never implemented. The current design treats everything as a warning. I would consider it as a bug if vscode raises any errors at...

@alisnic ```bash npx oxlint@latest --deny-warnings echo $? ``` This is not printting `1`? `--deny-warnings` won't change the final text from "Found 1 warning and 0 errors" to "Found 0 warning...

I can fix this now after changing how diagnostics work under the hood https://github.com/oxc-project/oxc/blob/f6daf0b7ae4fb9a3ac9e8520824eb06a278c78ea/crates/oxc_diagnostics/src/lib.rs#L47

Next version: Breaking change: * `--deny` / `-D` from the CLI and `error` from configuration file will report diagnostics as severity "error". * `--warn` / `-W` from the CLI and...