Boshen
Boshen
> I just noticed that #2637 is a thing, I'm going to only work on the hook rules. https://github.com/oxc-project/oxc/pull/2637 is stale, maybe you can help out and merge the code...
> @Boshen I wanted to implement these, I've noticed that the command `just new-react-hooks-rule ` doesn't work; I can create the rule manually I just need to know what should...
> > > @Boshen I wanted to implement these, I've noticed that the command `just new-react-hooks-rule ` doesn't work; I can create the rule manually I just need to know...
https://github.com/oxc-project/oxc/pull/3964#issuecomment-2198487332 No performance improvements after numerous attempts.
I'm in favor of modifying the task script.
Sounds good to me, leave this to me.
Fixed, we don't need to publish build.rs https://github.com/oxc-project/oxc/blob/b09092c9ecba74cbaa8fd42293cba5668889c4f9/crates/oxc_traverse/Cargo.toml#L14
Our CI pipeline disallows publishing untracked files, and I run `cargo check` prior to publish, so it won't be able to publish if things are accidentally unmatched. It'll probably won't...
@rzvxa Instead of doing the check inside the rule, are you able to mark the statement as unreachable during the cfg building phase inside semantic builder? For example add any...
Yes, a `run_once` through the entire CFG can do the trick! Assuming you can query out the unreachable spans.