Matthias Becker
Matthias Becker
> Unfortunately, I don't know in which CSS file this "background-color: unset;" is written down. There are too many CSS files. It's here: https://github.com/eclipse-platform/eclipse.platform.ui/blob/b6af990cac142bdba33768e29ec0d62482f0ba54/bundles/org.eclipse.ui.themes/css/e4-dark_mac.css#L44
windows build failure is unrelated. Plan to merge tomorrow if nobody objects.
I don't think that center-aligning the button brings an advantage.
Aligning the text and the checkbox is fine for me. I know this dialog a lot. I never felt it was wrong. But I think having the checkbox left aligned...
I think it's quite hard to add this from a user point of view. So you have to make clear to the user of the screensread which text is actually...
Which Eclipse version are you using? Is this a regression (meaning this was fine in previous version of Eclipse)
This sounds like a reasonable thing to do.
Does anyone from the other committers have any objections to merging this change?
Tested on macOS: It now looks like this: But without your change it looks also good: Can you pls. verify on your end? Did the issue maybe only occur while...
Pls. have a look at https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/progress/ProgressInfoItem.java#L835 There the code checks for the current themeID. Depending on this some colors are set. We should try to get rid of this color-setting...