[Light Theme]Fix for bg colors of entries in Progress View

[mvm-sap]

Fix for issue #2313 Issue has been fixed in all three platforms Win, Mac and Linux.

[mvm-sap]

@BeckerWdf Could you test once and confirm? Also, please update the screenshots as I have some issues uploading them.

[github-actions[bot]]

Test Results

 1 824 files  + 1 824   1 824 suites  +1 824   1h 31m 7s ⏱️ + 1h 31m 7s  7 925 tests + 7 925   7 697 ✅ + 7 697  228 💤 +228  0 ❌ ±0  23 862 runs  +23 862  23 114 ✅ +23 114  748 💤 +748  0 ❌ ±0 

Results for commit e00b8c50. ± Comparison against base commit 6a56d392.

:recycle: This comment has been updated with latest results.

[BeckerWdf]

Tested on macOS: It now looks like this:

But without your change it looks also good:

Can you pls. verify on your end? Did the issue maybe only occur while the theme as the "Light (Preview)" theme?

[BeckerWdf]

Pls. have a look at https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/progress/ProgressInfoItem.java#L835

There the code checks for the current themeID. Depending on this some colors are set. We should try to get rid of this color-setting logic and do this only in via the CSS files. But that would be a different issue / PR.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 8dbbd7537ce35850e9e5a042cf11884855a974f3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 6 Jun 2025 09:35:28 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
index 11d118fd4c..a1a0eafd86 100644
--- a/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.themes/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.themes;singleton:=true
-Bundle-Version: 1.2.2800.qualifier
+Bundle-Version: 1.2.2900.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.e4.ui.css.swt.theme
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[BeckerWdf]

@mvm-sap: I just tested this PR once again. But even without your changes in this PR I cannot reproduce the issue. The progress view looks good to me:

Do you still see this issue reported in https://github.com/eclipse-platform/eclipse.platform.ui/issues/2313 with Eclipse 4.36?

[BeckerWdf]

Closing as the issue can no longer be reproduced. Re-open if this is still an issue.