Matthias Becker
Matthias Becker
> My suggestion would be to merge both settings into one line instead of grouping them This is also a good idea.
Can the input field made shorter so that the line doesn't get too long. I think place for around 4 chars would be sufficient. What about changing the text to:...
> Close editor(s) if there are more than ... editors open yes.
> > Close editor(s) if there are more than ... editors open > > yes. Maybe without the () simply "Close editors if..."
merge commit are not allowed in PR. Can you pls. squash and rebase on top of current master please?
@mickaelistria: We would like to finish this early when master opens up again. Can you pls. again have a look and thought about @Christopher-Hermann's comments?
testCreateAndRunWorkbench (RcpTestSuite PlatformUITest) is unrelated and documented in https://github.com/eclipse-platform/eclipse.platform.ui/issues/1517 Regarding: testCancellingWhenRunning (org.eclipse.jface.text.tests.reconciler.FastAbstractReconcilerTest) I could not find an issue for that. Assertion message is: "reconciler never ran in 5 seconds". @Christopher-Hermann:...
> My next step is to check how the condition `isThemed` is being checked. The function `getCustomThemeFlag` returns isThemed by checking whether the active theme is equal to the default...
> Yes, I tested these out by the following criteria. This means isThemed is true for these screenshots?
Closing as the issue can no longer be reproduced. Re-open if this is still an issue.