Matthias Becker
Matthias Becker
> I tested this in macOS Sonoma, and the PR looks good visually. I haven't reviewed the code changes, but from a visual perspective, the change looks good. @elsazac: Can...
> I just changed the description of this PR for you :-) Thanks a lot. I overlooked this.
> but should we get an opinion from @lshanmug ? Sure why not.
For macOS we now have a fix of that. Can somebody have a look into this for linux and macOS?
> To my knowledge, there doesn’t seem to be an option to adjust the brightness through the Win32 API. Thanks for finding out. > I plan to investigate how this...
> FYI On Linux we have a little trick - defer to Gtk/OS to do that for us whenever dark theme is chosen (https://github.com/eclipse-platform/eclipse.platform.ui/blob/954bc581051c3f0a5ebcacc1d85492d2acd85707/bundles/org.eclipse.e4.ui.swt.gtk/src/org/eclipse/e4/ui/swt/internal/gtk/DarkThemeProcessor.java#L48) . All that it does is...
So should we then close this issue or keep it open waiting for some new possibilities in the Win32 API?
> Conclusions: Windows theming issue, not an SWT bug. What does that mean? You mean it's a bug of Windows?
> It's hard to say if it's a "bug" or "design decision". SWT relies on how Windows styled things, but Windows decided to style it differently in Win11. Will that...
> It should be easy to work around (not perfectly, but good enough) using this (partly) pseudo-code > > ```java > final int margin = getDpiScalingFactor(display); > final Rectangle size...