Matthias Becker
Matthias Becker
what I like with the proposed change is that the black circle is much bigger then the little tiny "*" we use today. And also the width of the tab...
> Did you consider using some highlight indicator (like for the currently selected tab) to indicate unsaved tabs? Something like this: >  I would not use the same indicator...
Can you pls. provide a screenshot showing the new dialog?
> > Can you pls. provide a screenshot showing the new dialog? > > Dialog looks like this with this fix.  Maybe User, Host, etc. should be written in...
> All the review suggestions are fixed. How does the UI look now?
> Display: :1 Especially this looks strange because of the two ":". I knot that's they displays are called. Maybe we should put all the values into single or double...
> > Especially this looks strange because of the two ":". I knot that's they displays are called. > > Display has format `:.` so the format can potentially be...
> I have introduced tab spacing and single quotes for the lock owner details. Now the dialog looks like this. That looks nice now. Thanks
Yes. In the new layout we can get rid of them from my point of view.
> > IIRC we also configure the SWT colors according to the theme but they are set to late during startup. > > @azoitl tried to fix this a long...