Matthias Becker

Results 217 comments of Matthias Becker

> For EMF-based editors, the properties view is a principle focal point when editing a model. Here is how things used to look: > > ![image](https://private-user-images.githubusercontent.com/208716/358494424-f6b7d26f-d68a-4b79-80cd-0c70da6bbf81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjcwNzYwMzYsIm5iZiI6MTcyNzA3NTczNiwicGF0aCI6Ii8yMDg3MTYvMzU4NDk0NDI0LWY2YjdkMjZmLWQ2OGEtNGI3OS04MGNkLTBjNzBkYTZiYmY4MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkyM1QwNzE1MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05OGNkMDM5NTZhMzYwMWY2N2Q0ZWY4MWFjNDRhOTQzNGIyOTU5NTA4NzNlZDA5YTExNDJmNzI4YThiZjkzMzM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xeGO_UtXBcEFxCr4cjdtC635EDeMqYRpEahkne37JIE) > > This is...

see https://github.com/eclipse-platform/eclipse.platform.ui/pull/2144 for this. Maybe you can help @mvm-sap with your knowledge to fix the remaining issues in that PR.

> i.e. this CSS entry did the coloring: > > ``` > CTabFolder Canvas { > background-color: #F8F8F8; > } > ``` > > https://github.com/eclipse-platform/eclipse.platform.ui/blob/b06fb4736ef968ed4b7a143084dad7f86b1bfd86/bundles/org.eclipse.ui.themes/css/e4_default_win.css#L74 > > Adding that to...

@jukzi: Can you pls verify and close?

> Fixes #1317 I don't see the relation to that issue. Can you pls. explain?

> I guess the subjective feeling is also because eclipse IDE still shows high contrast icons in front of the name which makes the low contrast text have less contrast...

Replaced with https://github.com/eclipse-platform/eclipse.platform.ui/pull/2294

@mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back?

> > @mvm-sap: Was this change by intention? If yes: Why. If not: Can we get the old color with the better contrast back? > > Yes, we followed VS...