eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Moving TabFolderLayout into SWT.

Open deepika-u opened this issue 1 year ago • 8 comments

Moving TabFolderLayout into SWT.

Fixes https://github.com/eclipse-platform/eclipse.platform.swt/issues/1317

This pr needs to be merged after https://github.com/eclipse-platform/eclipse.platform.swt/pull/1402

deepika-u avatar Aug 13 '24 09:08 deepika-u

Fixes #1317

I don't see the relation to that issue. Can you pls. explain?

BeckerWdf avatar Aug 13 '24 10:08 BeckerWdf

Fixes #1317

I don't see the relation to that issue. Can you pls. explain?

I fixed the link, it is meant to be

  • https://github.com/eclipse-platform/eclipse.platform.swt/issues/1317

laeubi avatar Aug 13 '24 10:08 laeubi

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 49m 15s ⏱️ - 7m 2s  7 712 tests ±0   7 484 ✅ +1  228 💤 ±0  0 ❌  - 1  24 297 runs  ±0  23 550 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit 6bb53dbc. ± Comparison against base commit 0a3c1fd3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 13 '24 10:08 github-actions[bot]

We can’t just delete it can we? It’s API.

merks avatar Aug 13 '24 10:08 merks

Its internal ... but I suspect there might be (internal) references that needs updates?

laeubi avatar Aug 13 '24 10:08 laeubi

Sorry I missed the internal in the package name.

merks avatar Aug 13 '24 10:08 merks

Its internal ... but I suspect there might be (internal) references that needs updates?

Definitely there would be some references as per my expectation. But how can i know where all it is referring? and what all files needs the respective updates. Could someone point me to a file which lists those failures or something?

deepika-u avatar Aug 13 '24 12:08 deepika-u

The best would be to first finish the SWT one so the new one is available.

Then you can setup a platform-sdk-ide and use the usual "Find References" search, and replace all usages with the SWT one.

laeubi avatar Aug 13 '24 13:08 laeubi

Please make sure that the bundles require new enough swt that has that api.

akurtakov avatar Oct 23 '24 12:10 akurtakov

@akurtakov : Can you please check now? I have updated bundle versions as well now.

deepika-u avatar Oct 24 '24 12:10 deepika-u

Jenkins fails due to OOM. I'm merging this one despite it.

akurtakov avatar Oct 24 '24 14:10 akurtakov