Matthias Becker

Results 217 comments of Matthias Becker

What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think?

> > What about bringing #000000 back for the selected tabs and maybe have #3b3b3b for the unselected tabs? What do you think? > > Both in view and editor...

This is addressed it in: https://github.com/eclipse-platform/eclipse.platform.ui/pull/2294

I think this is fixed (see above). Pls. reopen if you disagree.

> Doesn't work so well when one uses a code format where opening braces of a block begin on a new line: ![workspace-os_-polyde-cli_src_main_java_org_polyde_cli_Polyde_java-_Eclipse_IDE.pdf](https://github.com/user-attachments/files/17049325/workspace-os_-_polyde-cli_src_main_java_org_polyde_cli_Polyde_java_-_Eclipse_IDE.pdf) For such formats the previous line should...

> Implementing fix for gutter line background change in dark theme for Win and Mac. Ref 4th issue reported in [#2114 (comment)](https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114#issue-2418424128) > > ![image](https://private-user-images.githubusercontent.com/56332955/354101274-38fde361-9447-4bb9-b649-5dd1fe6ca2f6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0OTM5NDksIm5iZiI6MTcyMjQ5MzY0OSwicGF0aCI6Ii81NjMzMjk1NS8zNTQxMDEyNzQtMzhmZGUzNjEtOTQ0Ny00YmI5LWI2NDktNWRkMWZlNmNhMmY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAxVDA2MjcyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg4YjhhZWMzOTQ5MjVjYjc3Y2IzN2NhMDMwZDE4MzYzN2RmOTEwNDY3MTA5Y2RjYjBiZjIwNDU0MjFkMzZkNDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._QGw9xXTimF1eo4c-i8fl9HsqG8bLaSm-0K76a_AdGw) > > ![image](https://private-user-images.githubusercontent.com/56332955/354101351-0435f8c0-58ce-4859-b6ca-c7f25e12db4b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0OTM5NDksIm5iZiI6MTcyMjQ5MzY0OSwicGF0aCI6Ii81NjMzMjk1NS8zNTQxMDEzNTEtMDQzNWY4YzAtNThjZS00ODU5LWI2Y2EtYzdmMjVlMTJkYjRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAxVDA2MjcyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYzMmI3MTNiMWQwODJkODM3NDZhNTY5MzNmZDkwYjUxNzcxYmJhODlmMzc5YjliMWExYmNmMmU2MjczNzg0YzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TVQ44oS04fPFqREcmhu2DrbBVKrutdzen-4olYXnMHg) > I...

ok now I get it. Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot.

> > Can you pls. also explain what exactly you did change in the CSS spy? For me that's not so clear from your screenshot. > > Changed the background...

This is replaced by https://github.com/eclipse-platform/eclipse.platform.ui/pull/2744/

> * and place the icon within a "theme" directory, with the same file path as the original icon So this implies only icons that originally come from a file...