Change to font colors in selected/unselected tabs in views and editor
Change to the existing light theme https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114 also involved the change to the font colors of selected and unselected tabs in views and editors. This led to an issue from a user https://github.com/eclipse-platform/eclipse.platform.ui/issues/2182.
Selected tab in Views and Editor now has #00000 color code Unselected tabs in Views and Editor now have #3b3b3b color code This change has been done to improve the contrast between font color and background color of tabs. Please let us know your views.
Screenshots can be found here.
Before:
After:
@jukzi: What's your opinion?
Test Results
0 files - 1 510 0 suites - 1 510 0s :stopwatch: - 1h 1m 47s 0 tests - 7 688 0 :white_check_mark: - 7 460 0 :zzz: - 228 0 :x: ±0 0 runs - 22 385 0 :white_check_mark: - 21 839 0 :zzz: - 546 0 :x: ±0
Results for commit 63a0561c. ± Comparison against base commit 8ad21aa2.
:recycle: This comment has been updated with latest results.
Looks better but still feels to pale at the inactive tabs:
Maybe one can get used to it. But by now i would still prefer the old contrast. I guess the subjective feeling is also because eclipse IDE still shows high contrast icons in front of the name which makes the low contrast text have less contrast then the icons. But i don't need to focus on the icons. The text is the important thing.
"VS Code" and other IDEs not have those problem because they have general other layout without icons and a low contrast content in the problem view:
I guess the subjective feeling is also because eclipse IDE still shows high contrast icons in front of the name which makes the low contrast text have less contrast then the icons.
That's an interesting idea. Btw: You can turn off the icons on view tabs in the preference. Then this issue no longer exists.
issue still exists because it does not disable the high contrast in the editor icons
Replaced with https://github.com/eclipse-platform/eclipse.platform.ui/pull/2294