Anna Shaleva

Just for the record: here's some statistics for OnPersist/PostPersist triggers: **OnPersist:** ``` anna@kiwi:~/Documents/GitProjects/nspcc-dev/neo-go$ tail stat_onPersist_sorted_2.txt 2024-10-18T20:54:50.914+0300 INFO NTF {"trigger": "OnPersist", "height": 4555186, "container": "3b03f0b434c8b535b3a33cb2c811fc4efc8c602ca54f4b2d6578490b797ff843", "count": 513 2024-10-18T20:54:50.920+0300 INFO NTF {"trigger":...

Moved Notary functionality from Domovoi under Echidna hardfork.

Oh-oh, probably need to move it under next hardfork. Ref. https://github.com/nspcc-dev/neo-go/pull/3554 and https://github.com/neo-project/neo/pull/3454.

@roman-khimov, I can't request review from copilot, do I need some extra rights for that?

>--- FAIL: TestDBRestoreDump (0.10s) --- PASS: TestDBRestoreDump/excessive_restore_parameters (0.00s) panic: item with id = -10 and key = 0a is not initialized [recovered] panic: item with id = -10 and key...

> 1. (coding) actor's underlying slice of signer is mutated We need to extend actor's documentation to describe this behaviour. It should be explicitly prohibited to modify the signers passed...

> // > The resulting transaction can be changed in its Nonce Random nonce is embedded into transaction constructor, I doubt we need to change it and it doesn't cost...

But you may just change the resulting unsigned transaction. Calculation overhead is insignificant.

Not fixed, failure discovered in #3387 rebased onto fresh master. The error is: ``` 2024-04-01T16:07:03.8231740Z === RUN TestAwaitUtilCancelTx 2024-04-01T16:07:03.8234450Z logger.go:146: 2024-04-01T16:05:21.609Z INFO initial gas supply is not set or wrong,...

Fails with another error case after the last fix. Discovered in https://github.com/nspcc-dev/neo-go/pull/3385. ``` 2024-04-02T17:00:47.8155910Z === RUN TestAwaitUtilCancelTx 2024-04-02T17:00:47.8157740Z logger.go:146: 2024-04-02T16:59:13.596Z INFO initial gas supply is not set or wrong, setting...