Anna Shaleva

Results 251 comments of Anna Shaleva

https://github.com/nspcc-dev/neo-go/actions/runs/8999180144/job/24720829287?pr=3431 ``` 2024-05-08T09:08:22.2302570Z === RUN TestAwaitUtilCancelTx 2024-05-08T09:08:22.2303839Z logger.go:146: 2024-05-08T09:07:47.584Z INFO initial gas supply is not set or wrong, setting default value {"InitialGASSupply": "52000000"} 2024-05-08T09:08:22.2305426Z logger.go:146: 2024-05-08T09:07:47.584Z INFO P2PNotaryRequestPayloadPool size is...

``` 2024-11-15T12:03:28.8462286Z === RUN TestAwaitUtilCancelTx 2024-11-15T12:03:28.8464208Z logger.go:146: 2024-11-15T12:02:58.898Z INFO initial gas supply is not set or wrong, setting default value {"InitialGASSupply": "52000000"} 2024-11-15T12:03:28.8467076Z logger.go:146: 2024-11-15T12:02:58.898Z INFO P2PNotaryRequestPayloadPool size is not...

> wrapper generates: > > // RoyaltyInfo invokes `royaltyInfo` method of contract. > func (c *ContractReader) RoyaltyInfo(tokenID []byte, royaltyToken util.Uint160, salePrice *big.Int) ([]stackitem.Item, error) { > return unwrap.Array(c.invoker.Call(c.hash, "royaltyInfo", tokenID,...

@AliceInHunterland, ready for review?

I'm not allowed to request review, set labels or resolve conversations. Maybe someone from neo-project with access rights can allow me at least to request review?

> may you please add comments to explain CalculateNetworkFee. Sure, fixed.

> GAS.OnPersist change is missing for the attribute. Completely forgot about it, fixed.

> Maybe this PR we merge after next release. This PR doesn't hurt because currently in real network NotaryAssisted attribute is always invalid since transaction must have Notary contract as...

> For me is good if this was implemented @shargon, the test is added, it works as expected. Please, check out the https://github.com/neo-project/neo/pull/3178/commits/670546971648b0c16f81b6a94a80b697e70242ab. @Jim8y @vncoelho @cschuchardt88 and everyone interested, we...

> I am aligned with @vang1ong7ang and I will wait until his recommendations are all clarified. @vncoelho, @vang1ong7ang There are replies (https://github.com/neo-project/neo/pull/3175#issuecomment-2019433661, https://github.com/neo-project/neo/pull/3175#issuecomment-2007050274), so could you please specify the exact...