Anna Shaleva

Results 251 comments of Anna Shaleva

@shargon, > @AnnaShaleva just to clarify, when you said backup is a non primary or a primary backup? The issue is related strictly to dBFT 2.0, we do not consider...

@vncoelho, > In that case, Replicas may still commit at view 1. Based on the code-level definition of `MoreThanFNodesCommittedOrLost`, that's true. We've adjusted the definition of `MoreThanFNodesCommittedOrLost` in our TLA+...

@vncoelho, After discussion with Roman I need to adjust the previous comment: `MoreThanFNodesCommittedOrLost` in our TLA+ specification implemented as `MoreThanFNodesCommitted`. We've adjusted the way we count committed nodes to consider...

> This raises so many compatibility questions that I don't even know where to begin. Addresses/wallets/script parsers/NeoFS accounts/NeoX accounts. Just to be in sync with Discord: we've discussed it with...

Something has happened with the `Neo` unit-tests, they are hanging (checked this locally, the result is the same): ``` Neo.GUI -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/bin/Debug/net8.0-windows/Neo.GUI.dll Neo.UnitTests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll (.NETCoreApp,Version=v8.0)...

@shargon, I've fixed the test, please, see the last commit. Now all tests are passing and the logic works as expected. Let's review this PR one more time (if needed)...

> By the way, do you know how many core modules will be affected by this notary feature? Is this the last PR? To be able to *process* existing NeoFS...

> and is there a fork introduced? This PR changes the states, because we need Notary contract to be presented in the genesis block. And it's intentionally that we don't...

More tests are added, need to update to master once #3190 is merged for successful test runs.

Updated to fresh master, more tests added.