Anna Shaleva

Results 251 comments of Anna Shaleva

I don't have any special preferences on this topic, Fernando's option is a bit easier to implement and follow, Roman's one is more compact. Maybe if we have this problem...

@Jim8y, we can't approve it yet, we firstly need to decide on https://github.com/neo-project/proposals/pull/160#pullrequestreview-2074421878. @neo-project/core, need your opinions on this topic.

Also please, add one more compatibility test from https://github.com/neo-project/neo/pull/3557: `(5 ^ -1) % 4 == 1`

@AliceInHunterland, https://github.com/nspcc-dev/neo-go/issues/2628 is not needed, so exclude it from the list. Also, add the improvements suggestion from https://github.com/nspcc-dev/neo-go/issues/3097#issuecomment-2191090318.

About this error: ``` Error: Expect "Error: failed to decode prefix from hex: encoding/hex: invalid byte: U+002D '-' " to match "02: 02" ``` Try to remove `e.checkStorage` lines and...

> About this error: I see that it's a VM handler error, thus try to look at the argument provided to `prefix, err = hex.DecodeString(c.Args().Get(1))`.

Also, please, include this change: https://github.com/nspcc-dev/neo-go/pull/3477#discussion_r1654571447.

> Also was thinking about unified Usage text. Not in this PR, let's create an issue for that.

BTW, it should likely be `netmode.MainNetNeoFS` and `netmode.TestNetNeoFS` to match the embeds: https://github.com/nspcc-dev/neo-go/blob/5566e354d451fd14d3b2a856cfe4b1b654a7343e/config/config_embed.go#L24-L32

> or we need to be consecutives? Huh, we don’t have to. Seems that’s exactly the case of special numbers: > Assign a NEP number (almost always just the next...