Anna Shaleva
Anna Shaleva
@neo-project/core, a batch of tests is added, rebased onto fresh master and ready for review.
> however, at least, maintain it as a hardfork Good, then let us check if NeoFS networks are compatible with hardfork-dependent Notary contract. I'll write the results here and update...
> But why do you need it? Agree, the default settings are not supposed to be used for NeoSystem creation. You always need network-specific settings since Committee members depend on...
I think there's a couple of places in the neo-devpack that needs to be updated as far.
A part of this issue (methods' "active till") is implemented in the https://github.com/neo-project/neo/pull/3234. We need to implement events' "active till" (ref. https://github.com/neo-project/neo/pull/3234#discussion_r1601112014) and improve ContractMethodAttribute constructor (ref. https://github.com/neo-project/neo/pull/3234#discussion_r1601104782).
> Do you have benchmarks? Well, I think it's a question to @vang1ong7ang, since I'm stick to the second option, to keep it as it is now.
> its because you run too many nodes in the same machine that all use leveldb It was not a problem for me either, I used NeoBench to run 4-nodes...
A nice improvement, let's adjust an error text for now. Later it may be proposed to include magic to the dumps.
It starts from the genesis by default, thus, it's `dump`'s usage should be adjusted.
A little bit more relevant with https://github.com/neo-project/neo/pull/3513.