Anna Shaleva

Results 251 comments of Anna Shaleva

@neo-project/core, let's try to review one more time, if you have any specific test cases or a possible vector of attack on your mind, then please, comment. This PR is...

> need changes from https://github.com/neo-project/neo-modules/pull/884 here. Sure, will port it ASAP.

Also need to move Policy update under Domovoi hardfork to keep our states unchanged, depends on #3290.

We've checked that NeoFS networks are 100% compatible with both Notary contract and NotaryAssisted attribute enabled starting from D hardfork (see the https://github.com/nspcc-dev/neo-go/issues/3465). It means that Notary contract and NotaryAssisted...

UPD: we're aware of the Technical Committee decision to postpone the Notary subsystem implementation. However, we think that it's good to keep this code up-to-date wrt the current master so...

@neo-project/core let's resume our work on this PR. I've updated it to fetch fresh master, NotaryAssisted attribute will be enabled starting from Echidna.

@Jim8y @vncoelho @cschuchardt88 need your review here, we've agreed to move on with this PR, and we need it to be a part of 3.8.

> You have errors that need fixing 1st. Thanks for pointing that out, it was due to recent testing framework upgrade happened on master. Unit-test is fixed (see the latest...

I vote for option with `` since it allows to clearly identify flag example and multi-words flags look more recognizable with ``.

>but it complicates things at the same time (especially given the fact that VM doesn't distinguish them) Vote up if we make this `length` parameter optional (or maybe create one...