Hadrien Croubois

Results 626 comments of Hadrien Croubois

Note: if we do this change, then `type(IERC6909ContentURI).interfaceId` will change, as it will no longer include `contractURI()` in its computation. ERC165 is not part of ERC6909 specification, but I still...

Given that ERC-6909 does NOT mention ERC-7572 ... and that ERC-7572 does NOT mention ERC-7572 either ... I think we shouldn't do this change. Closing this PR. If there are...

@ernestognw for the record this is usefull for the confidential tokens. They need a checkpoint structure where the "value" is a bytes32/uint256 (encrypted value pointer)

Hello @dilumb > This change would enable developers to selectively expose these events through interfaces without requiring manual modification of the ABI. I'm not sure I understand what this means....

I'm confused by what exactly you are asking. What I understand is that you want multiple entities to have different views of a contracts (I personnally don't think this should...

@frangio I think that upgrade to the transient layout vulnerability would be awesome for an Underhanded Solidity Contest.

This is something we discussed during development, and we figured out would not happen in any "realistic" use case: - Let assume a token with 36 decimals (that is a...

> The total supply could easily be uint256.max Our (past) analysis showed that real tokens are veryyyyyyy far from that. Do you know any real usecase were token have such...

Hello @techvoyagerX We run test coverage using hardhat and solidity-coverage. Coverage run is done using `scripts/checks/coverage.sh`. This is integrated into the CI, which validates a high level of coverage. Last...

While these changes make sens, they also significantly increase the cost of using this function. This woul affect contract such as protocole gateways, the open bridge, and other. We can...