Hadrien Croubois

Results 626 comments of Hadrien Croubois

- ~Do not transpile UUPSUpgradeable, ERC721Holder, ERC1155Holder~ (done in 5.5) - other stateless contracts?

We should decide weither we are ok with the following feature: - Memory slices (in memory.sol ?) - Bytes accumulator (in bytes.sol ? in a dedicated file under struct ?)...

We could use that feature, but it's still not available :/

While I do personally agree that `uint` as an alias to `uint256` creates more confusion than good, I'm not sure your example is really about that. I think you are...

> I even had people assuming that uint is an alias for uint64 That tipically sounds like some C/C++ héritage. Int and uint are usually 32 bits, and long often...

Ref: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5084#discussion_r1687475978

I'd say this is desirable, unless it triggers when compiling the "coverage" contract that are way bigger (because of the added events). CI shows that it should be ok, so...

The diff is completelly bugged. Changing base doesn't reset it

IMO this should be in the go in the community repo, with the account work. I feels very new, and weither we want it or not depends on the account...

Code an tests are making good progress, but the underlying ERC is still subject to a lot of discussion. Consequently, I don't think we should include that in 5.2. I'd...