Hadrien Croubois
Hadrien Croubois
IMO this PR should include the usage of this lib
Its sad we missed that in 5.3, as it is not controversial. Lets fix conflicts and make sure it gets into 5.4
Should be covered by #5094
Hello @demoncoder-crypto The usecase for onchain graph representation are unclear to me. If they exist, I'm not sure a generalised structure would fit these (possibly widelly different) cases. Before jumping...
Definitelly yes for `Bytes.sol`! For arrays, I'm not sure if we should have that only for bytes32[] ? For all value type (uint256[], address[], ...) ? For string[] and bytes[]...
Hello @Zohar97 This looks like a false positive from the zksync-cli. It looks like their system does not understand the use of an immutalbe variable that is shared by all...
Thank you @CodeSandwich for this idea. Backward compatibility is a must for us (because of the upgradeable version). Its good that you approach provides that feature! This limitation of balances...
As discussed yesterday, closing this PR.
I honestly don't understand why an address should be considered differently from a bytes20 or a uint160. This "maybe not a bug" is pushing us to cast objects that are...
I'm wondering if we should have multiple datastructures, versus having just one structure (bitmap) with functionallity to read//write multiple bits at once. What is the usecase exactly ?