Hadrien Croubois
Hadrien Croubois
Can you share the implementation of `claimWithdraw()` ?
I'm wondering if you can't already solve that with the function you have available. It feels to me like the values in your `requests` structure are sorted (that is what...
Should that be in Math, or should we start a `Byte.sol` file for this, and CLZ (and other) ? It doesn't feel like this is a math operation strictly speaking.
For the record, I tried seeing is assembly would save gas: ```solidity function reverseBits256(bytes32 value) internal pure returns (bytes32) { assembly ("memory-safe") { let mask // swap bytes mask :=...
It all looks good to me, except the name of the functions. Lets take the example of `reverseBits16`. The name sugest it reverses the 16 bits that compose the object....
# Code location (to discuss) - [ ] Entrypoint: `@openzeppelin/contracts/vendor` (mocks? other repo?) - [x] ERC4337 interface: `@openzeppelin/contracts/interface` - [x] ERC7579 interface: `@openzeppelin/contracts/interface` - [x] ERC4337 utils: `@openzeppelin/contracts/account/utils` - [x]...
While this looks good, I'd like to consider a different approach. See https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5681#issuecomment-2911597864
Some notes: - we agreed on keeping the `_reentrancyGuardStorageSlot()` name - for some stupid reason, `ReentrancyGuardTransientUpgradeable` is not seen as stateless, and there is an Upgradeable version of it. We...
Closed in favor of #5892 (cannot modify this PR's code)
Would be usefull for #5762