AlekseyTs

Results 107 comments of AlekseyTs

I prefer tool handling this scenario and also giving me the tally at the end. Also, not everyone is proficient with shell commands.

If we are talking about expressions that convert types, it looks like specification refers to them as Cast Expressions: "A cast expression coerces an expression to a given type. Specific...

Done with review pass (commit 3)

Consider an alternative approach - simply adjusting the wording of the error message to include the RHS of an assignment situation. For example, instead of saying: "Cannot assign to variable...

@cston, @RikkiGibson, @dotnet/roslyn-compiler Please review

@RikkiGibson, @dotnet/roslyn-compiler For the second review

> result = scope.LookupMetadataType(ref emittedName); Is this call going to allocate a missing symbol when lookup fails? --- Refers to: src/Compilers/CSharp/Portable/Symbols/NonMissingModuleSymbol.cs:203 in 86aedd9. [](commit_id = 86aedd93cecd94e16ba18fa1d578f82a170035fb, deletion_comment = False)

> CacheTopLevelMetadataType(ref emittedName, result); It doesn't look like we want to cache null here. --- Refers to: src/Compilers/CSharp/Portable/Symbols/NonMissingAssemblySymbol.cs:177 in 86aedd9. [](commit_id = 86aedd93cecd94e16ba18fa1d578f82a170035fb, deletion_comment = False)

Done with review pass (commit 1)

Done with review pass (commit 1 vs. 2)