AlekseyTs
AlekseyTs
I stopped reviewing implementation changes at iteration 15. I suggest simplifying it and following the suggested strategy more closely. #Closed
> compiler understands constant chars and lowers them to constant strings to avoid calling `char.ToString()`. I just extended compiler's abilities, so it can also understand `constantChar.ToString()` and do the same...
> I have a question for you regarding item 1 in your proposal: the suggestion looks reasonable but it seems to me that it is related not to our case...
>Are you ok if I replace existing tests, where we test positive scenarios with missing unimportant members 1 by 1 with equivalent ones, but where all unimportant members are missing?...
Done with review pass (commit 20) #Closed
Done with review pass (commit 21). The implementation changes are not fully reviewed, pending the suggested simplification. #Closed
Done with review pass (commit 24) #Closed
> } I think the problem with definition of new well known string members can be observed by adding a unit test like this one, but with ```ReadOnlySpan``` defined in...
Done with review pass (commit 32) #Closed
Done with review pass (commit 36) #Closed