AlekseyTs
AlekseyTs
Done with review pass (commit 42). The CI failures are likely due to issues in CI infrastructure. #Closed
>> I think the problem with definition of new well known string members can be observed by adding a unit test like this one, but with `ReadOnlySpan` defined in this...
Done with review pass (commit 43) #Closed
Done with review pass (commit 45) #Closed
@cston, @jjonescz, @dotnet/roslyn-compiler Please review.
> var src1 = @" > In general, why are you not using raw string literals, at least for new tests? Personal preference. I got used to tests looking a...
> public void ConstructorSymbol_02([CombinatorialValues("class ", "struct")] string keyword) > "class" (no trailing space) This makes strings the same length and aligns diagnostics position, when we have one. I don't think...
> public void AttributesOnPrimaryConstructorParameters_09_CallerMemberName([CombinatorialValues("class ", "struct")] string keyword) > Why 09 when the previous test is AttributesOnPrimaryConstructorParameters_02? Even though that might come as a surprise at first. There is no...
> Assert.Equal(0, analyzer.FireCount3); > Consider adding comments to places where fire counts are zero. At least, I don't understand why is that the case. The analyzer tests are clones of...