roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

TextLoader method override detection

Open tmat opened this issue 1 year ago • 2 comments

Implements pattern used by BCL to deprecate public abstract methods:

  • Update old method to call the new method.
  • Change abstract to virtual if needed
  • New method:
    • Use reflection to ask if the old method was overridden.
    • If it was overridden, call it, otherwise call old method.

We can still stack overflow if the old method is overridden but calls the base implementation.

tmat avatar Sep 21 '22 18:09 tmat

@333fred @jasonmalinowski @AlekseyTs

tmat avatar Sep 21 '22 23:09 tmat

Done with review pass (commit 1)

AlekseyTs avatar Sep 22 '22 17:09 AlekseyTs

Done with review pass (commit 1 vs. 2)

AlekseyTs avatar Sep 23 '22 17:09 AlekseyTs

Done with review pass (commit 5)

AlekseyTs avatar Sep 26 '22 22:09 AlekseyTs

/azp run

tmat avatar Oct 19 '22 15:10 tmat

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Oct 19 '22 15:10 azure-pipelines[bot]