AlekseyTs
AlekseyTs
Done with review pass (commit 14)
> // check that the corresponding `*ConstantAttribute` is available. It is not clear to me why this check was relevant here and isn't relevant any more. It feels to me...
Done with review pass (commit 40)
Done with review pass (commit 46)
> if (isSynthesized && defaultValue != ConstantValue.NotAvailable && Dropped the ``` != ConstantValue.NotAvailable``` check. Doesn't look intentional. #Closed --- Refers to: src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs:793 in 589ff29. [](commit_id = 589ff29cd98b87c45a20c28eb312477125886c02, deletion_comment = True)
> if (isSynthesized && defaultValue != ConstantValue.NotAvailable && I see, that was equivalent to the null check --- In reply to: [1358063599](https://github.com/dotnet/roslyn/pull/65777#issuecomment-1358063599) [](http://example.com/codeflow?ancestors=1358063599) --- Refers to: src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs:793 in 589ff29. [](commit_id...
> Local functions behave the same way (the default value is not propagated; see ... . Should they be fixed, too? What behavior you are referring to? Could you be...
> The propagation already happens for non-decimal constants as demonstrated above. Shouldn't it be more consistent? In general, consistency is good. However, it would be good to understand was there...
@jjonescz > > The propagation already happens for non-decimal constants as demonstrated above. Shouldn't it be more consistent? > > In general, consistency is good. However, it would be good...