Admiral H. Curtiss
Admiral H. Curtiss
The reason I'm against using the display name, for reference, is that that may contain an arbitrary string that may not even be resolvable in the current file system. For...
I'm not sure whether this really needs two separate UI options, or even two separate INI options... Is there a good reason to not just connect the existing compression level...
For those cases where you use `StringPopFrontIf()`: It likely doesn't matter much here because the strings aren't super long, but you'd be better off making a `string_view` instead and removing...
Minor quibbles aside, this looks good. Very useful too, although I don't fully understand how I'm supposed to use the `v`/`V` formatting flags. Our Breakpoint UI could use a serious...
Ah there was a hidden const_cast in there before, that's even more sketchy. Well either way, fair enough, I just saw the blog post and my brain went 'wait this...
It's been some time but I want to say that I made those custom ones? The history over at https://github.com/barronwaffles/dwc_network_server_emulator/tree/master/dlc/IRAO suggests that too. I wanna say those were combined from...
I think that still results in platform inconsistency (consider eg. platforms where long is 64 bit vs platforms where long is 32 bit), but feel free to give it a...
I have a feeling the custom FatFS modifications are going to cause us headaches in the future if we, say, ever want to update FatFs... As far as I can...
I have done some refactoring on the FatFs code so that this can work without having to actually touch the external code. Please check if the code at #11107 still...
You, uh, need some help here?