Admiral H. Curtiss


Yeah, I think JMC summarized it pretty well, but: - No Save Data -> No sava data is loaded from anywhere, and save data is discarded after the netplay session...

Anyone wanna give more comments here? I'd like to see this merged sometime.

Yeah, I like this, but you're right that the address used for Set value from file might be unclear. Maybe rename it to something like... I dunno, 'Load file to...

?? What do you mean 'neither supports'? It's just part of the commit message, and you clearly can write commit messages.

Two things: - While I agree that removing the VS Project files is a good idea in general, first we need to ensure that the CMake project actually does the...

I assume it's js because that's what VS build scripts support? I also see no reason why we need to invoke python for this, we have this set up at...

For reference, Dolphin's CMake files already do this, it's just not properly re-executed when the commit changes: https://github.com/dolphin-emu/dolphin/blob/1088021e39750c22ba622ab9e5065ffc32cb0e39/CMakeLists.txt#L165-L216 https://github.com/dolphin-emu/dolphin/blob/1088021e39750c22ba622ab9e5065ffc32cb0e39/CMakeLists.txt#L974-L986

Please make the CMakeLists.txt change a separate PR.

I'm not convinced the CMake build files use the correct flags yet. Taking a random file: CMake in Debug mode: ``` build Source\Core\AudioCommon\CMakeFiles\audiocommon.dir\AudioCommon.cpp.obj: CXX_COMPILER__audiocommon_Debug dolphin\Source\Core\AudioCommon\AudioCommon.cpp || cmake_object_order_depends_target_audiocommon DEFINES = -DAUTOUPDATE=1...