Admiral H. Curtiss
Admiral H. Curtiss
Yes, it feels a bit magic otherwise. You also have a bug in here if the string starts with `n` : https://godbolt.org/z/PMoPWxfG1
A mid-string `n` not preceded by a `_` is also not handled correctly...
I don't understand why you're checking for the prefix in the middle of the string and then rejecting the result if it's not at the start. Is there any reason...
> If you don't want people to make style changes, change the style. Minty won't be the first to reasonably think that it is good for Dolphin's code to match...
Please squash all of these fixups.
Can you post some instructions on how to use this, exactly? To clarify, I am completely unfamiliar with this format, how it is used on console, and what it is...
All fair points. Perhaps a better approach is needed here.
I'm not convinced your first change actually does anything? It already returns a nonconst pointer and I see no place that could possibly produce a copy.
Also you probably need to explain the second one in more detail, how exactly does that fix the issue? e: Is that even safe? The generated loader (and layer) stores...
It says `::iterator` right there in the second line, what are you talking about??