Admiral H. Curtiss

Results 369 comments of Admiral H. Curtiss
trafficstars

Harmless means you can ignore it.

As far as I can tell this is just a visual bug, the Copy and Move buttons are greyed out but still work just fine if you press them.

So I re-checked this and I was partially right. The buttons are greyed out, the Copy button works regardless, but the Move button does not. Additionally, games with partially copyable...

I'll ask again, what's the hold up here?

Personally I'm not happy with more global state, and I also don't really understand why this works -- which also means I can't tell if this breaks anything.

fwiw since I think our TAS setup logic needs a big overhaul anyway (like, in terms of letting the user configure what settings they want to start with) and since...

This has been sitting here for a while and we're a few weeks away from a beta, so I'm just gonna merge this, alright?

https://github.com/dolphin-emu/dolphin/pull/11058#issuecomment-1252493999 looks more likely related to this PR.

I'm still not 100% happy here but since this is well documented as a hack and very tiny, sure, whatever.

fwiw If you want to open a PR for just the INI setting I see no reason to not just merge it.