Admiral H. Curtiss

Results 388 comments of Admiral H. Curtiss

Does someone want to review this, code-wise? I'd like to get this in and JMC said he's fine with the UI.

Frankly I don't understand it but sure, that's easy enough to do.

This has been sitting here forever with no comments, I'm just gonna merge this...

Please filter before you construct the objects that would never be used if filtered out anyway (in fact, I think you're leaking memory here). I would also prefer if the...

Hey this actually builds now with the build server upgrade, great!

Yeah I think we can use a submodule. Regarding WIL, I'm not quite sure how to design this as-is with WIL? I guess it would in general be better to...

We could have a cubeb worker thread that gets function calls to execute via a queue, if that's better.

7c8dd95bf6ab0abc43c6baddb29e9d341cff7f5a is a variant using a worker thread. It's a bit ridiculous, but maybe actually the better option? Avoids the CoInitialize on the main thread and never opens any temporary...

I think allowing a separate user GameINI for mod descriptor files is sensible. However, I would recommend instead making a new field in the JSON that specifies where that INI...

Just make it a path -- like the path to the base ISO, relative to the position of the json file -- and default it to the same filename as...