Admiral H. Curtiss

To be extremely clear what is happening here: 

So what's the status here?

Can we get a review here of someone who's familiar with the DSP/Audio stuff?

I haven't looked over the code in particular but this seems mostly reasonable -- smart pointers are definitely a better idea than manual memory management, and if you think that...

It's the call to HashGroup() in EncryptGroup() I linked above: https://github.com/dolphin-emu/dolphin/blob/dcdba11ded671acff679b9183e0c3e1e52502a0f/Source/Core/DiscIO/VolumeWii.cpp#L591-L606 HashGroup() calls the given callback BLOCKS_PER_GROUP times, which causes the later reads of ReadWiiDecrypted() to go out of bounds...

Hm, I just tried again with just rounding to block size and it seems to work actually. I think I didn't set the decrypted rounded up data size of the...

The rest of the non-Android code looks fine from what I can tell, though I'm not super familiar with the input code.

Can we get a review from @jordan-woyak on this? I'd like to see this merged so we can inch closer to fixing that ridiculous Android input system. I suspect this...

find_package(LibLZMA) only defines a target as of CMake version 3.14 (according to the documentation anyway) but our minimum is 3.13.

@iwubcode @JMC47 Any comments on this?