ADmad
ADmad
I'll look into upgrading for Cake 5.x when I have some spare time but can't provide any time frame for it. Someone from the community is welcome to provide a...
@JustinRuiter You can open a new PR targeting the `cake5` branch of this repo, or wait for MolbioUnige to merge your changes and update his PR.
Can you please give an example of where you need to use a component and can't just use a service class instead directly in your action?
> This means that when we go to generate URL strings we need to build all routes as RouteCollection doesn't have a good way to skip route scopes yet. So...
We can just bake with `return Command::SUCCESS`.
As I mentioned on the related issue your PR needs to target the `cake5` branch not `master`, so please rebase your branch onto upstream ~~master~~ `cake5` and re-target the PR.
You just changed the branch target without rebasing and fixing merge conflicts :slightly_smiling_face:
Sorry, I made a typo in my previous comment, you need to rebase upon `cake5` not `master`.
> Could this be picked up in a seperate issue? Yup
Changing the return type as you suggest won't be backwards compatible if someone has overridden `Table::find()` and using `Cake\ORM\Query` as the return type.