ADmad
ADmad
There are issues with setting gender/sex in specific provider classes too. For e.g. the `Facebook` has https://github.com/SocialConnect/auth/blob/487293582eecdc2e23dd46330788a42cb5ae3e30/src/OAuth2/Provider/Facebook.php#L63 which seems pretty wrong given what the FB's Graph API says regarding the...
Values for all other properties can be `null` so there's no problem allowing the return value of `getGender()` to be `null` too.
Always returning `unknown` prevents differentiating between whether the provider returned `unknown` (for e.g. `none` in case of Meetup) or the provider doesn't allow / has ability to return gender at...
Personally I would just return the raw values and let the users marshal / convert it to standard values depending on what's used in their apps.
The failing test case needs to be fixed.
> Thanks for the feedback. I suppose it means creating a mockClientResponse at testGetIdentitySuccess for TwitchTest.php? Yes. > I am not sure when I have time to do this. Then...
> What would hold back allowing only full locales (lang_REGION) on I18n::setLocale as of 5.0? This issue is regarding the Translate behavior, not I18n::setLocale().
@Phally Hi, would you mind re-opening this against the latest master?
My only follow up for now is I would like to get it addressed/fixed :)
None currently. With the removal of `ModelAwareTrait` in Cake 5.x some major changes will be required to the plugin for 5.x compatibility. I haven't had the time to check /...