Webservice icon indicating copy to clipboard operation
Webservice copied to clipboard

Published 20 hours ago • verified publisher icon UseMuffin

CakePHP 5.x compatibility

Open asgraf opened this issue 1 year ago • 6 comments

Are there any plans for CakePHP 5.x compatibility?

asgraf avatar Jan 24 '23 12:01 asgraf

None currently. With the removal of ModelAwareTrait in Cake 5.x some major changes will be required to the plugin for 5.x compatibility. I haven't had the time to check / plan out what's required.

ADmad avatar Jan 24 '23 13:01 ADmad

Any plans to make this package compatible with CakePHP 5 once there is a stable version out? Thanks in advance

AdrianHL avatar Aug 17 '23 08:08 AdrianHL

I'll look into upgrading for Cake 5.x when I have some spare time but can't provide any time frame for it.

Someone from the community is welcome to provide a PR for the same. The ModelAwareTrait was finally retained for Cake 5 so that would the upgrade easier.

ADmad avatar Aug 17 '23 10:08 ADmad

A PR was opened to resolve this issue: https://github.com/UseMuffin/Webservice/pull/107 . This PR is halfway there and the CI wasn't updated, along with some typing and implementation issues. I solved this in my PR: https://github.com/MolbioUnige/Webservice/pull/1 . Any feedback for this would be greatly appreciated.

JustinRuiter avatar Mar 27 '24 09:03 JustinRuiter

@JustinRuiter You can open a new PR targeting the cake5 branch of this repo, or wait for MolbioUnige to merge your changes and update his PR.

ADmad avatar Mar 28 '24 08:03 ADmad

https://github.com/UseMuffin/Webservice/pull/112

JustinRuiter avatar Mar 28 '24 08:03 JustinRuiter