Webservice icon indicating copy to clipboard operation
Webservice copied to clipboard

Published 20 hours ago • verified publisher icon UseMuffin

Cake5

Open JustinRuiter opened this issue 1 year ago • 5 comments

An updated version of MolbioUnige's PR, to fix the pipeline and fix various typing issues.

PR into MolbioUnigue's repo: https://github.com/MolbioUnige/Webservice/pull/1

JustinRuiter avatar Mar 28 '24 08:03 JustinRuiter

Codecov Report

Attention: Patch coverage is 68.14815% with 86 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (cake5@e425ff6). Click here to learn what that means.

Files Patch % Lines
src/Datasource/Query.php 61.41% 49 Missing :warning:
src/Model/Endpoint.php 74.02% 20 Missing :warning:
src/Datasource/Connection.php 43.75% 9 Missing :warning:
src/Datasource/ResultSet.php 71.42% 2 Missing :warning:
src/Model/EndpointLocator.php 66.66% 2 Missing :warning:
src/Webservice/Driver/AbstractDriver.php 80.00% 2 Missing :warning:
src/Datasource/Schema.php 80.00% 1 Missing :warning:
src/Model/ResourceBasedEntityTrait.php 0.00% 1 Missing :warning:
Additional details and impacted files 
@@           Coverage Diff            @@
##             cake5     #112   +/-   ##
========================================
  Coverage         ?   81.51%           
  Complexity       ?      394           
========================================
  Files            ?       13           
  Lines            ?     1098           
  Branches         ?        0           
========================================
  Hits             ?      895           
  Misses           ?      203           
  Partials         ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 11:03 codecov[bot]

As I mentioned on the related issue your PR needs to target the cake5 branch not master, so please rebase your branch onto upstream ~~master~~ cake5 and re-target the PR.

ADmad avatar Mar 28 '24 11:03 ADmad

You just changed the branch target without rebasing and fixing merge conflicts :slightly_smiling_face:

ADmad avatar Mar 28 '24 11:03 ADmad

Sorry, I made a typo in my previous comment, you need to rebase upon cake5 not master.

ADmad avatar Mar 28 '24 11:03 ADmad

Sorry, I made a typo in my previous comment, you need to rebase upon cake5 not master.

Rebased

JustinRuiter avatar Mar 28 '24 13:03 JustinRuiter

I don't really have the time or expertise to implement the seperate query classes from core. Could this be picked up in a seperate issue?

JustinRuiter avatar May 06 '24 16:05 JustinRuiter

Could this be picked up in a seperate issue?

Yup

ADmad avatar May 06 '24 16:05 ADmad