ADmad

Results 347 comments of ADmad

`emptyTrash()` uses `Table::deleteAll()` which does not use callbacks. You can submit a pull request if you like adding a `$cascade` argument to the method and updating internals accordingly.

Besides deleting of associated records the use of `deleteAll()` in empty trash also causes the `afterDelete` callback not being run for the primary record. For e.g. if the primary record...

You could use `Connection::run()` to run the query and get a `StatementInterface` instance which you can iterate over, or just use pagination to fetch reports in chunks.

Put the `\n` in double quotes instead of single quotes.

Can you please provide a link to the relevant section of the RFC cause I can't find anything here https://www.ietf.org/rfc/rfc1035.txt regarding "localhost".

Hmm the standard is too broad and allowing any label as a hostname would make the validator useless for most practical purposes. IIRC in the past we decided to got...

Personally I would be okay with that, let's see what others have to say.

New features need to target `5.next` now and since changing the target branch will cause merge conflicts I am closing this for now. Feel free to reopen a new PR...

There's also a failing test which seems related to this change.