bake icon indicating copy to clipboard operation
bake copied to clipboard

Add @phpcsSuppress to `Command::execute`

Open cleptric opened this issue 2 years ago • 6 comments

PHPCS will complain about missing return-type hints when you bake your first command.

Method \App\Command\AppCommand::execute() does not have native return type hint for its return value but it should be possible to add it based on @return
    |       |     annotation "int|null|void".

PHPCBF then adds : int|null|null 🤔

cleptric avatar Oct 04 '23 22:10 cleptric

Is there no way to fix the actual phpcs rule to not throw wrong error?

dereuromark avatar Oct 04 '23 23:10 dereuromark

I would recommend opening a Bug ticket or pr for their repo

dereuromark avatar Oct 04 '23 23:10 dereuromark

We can just bake with return Command::SUCCESS.

ADmad avatar Oct 05 '23 02:10 ADmad

This pull request is stale because it has been open 30 days with no activity. Remove the stale label or comment on this issue, or it will be closed in 15 days

github-actions[bot] avatar Feb 03 '24 00:02 github-actions[bot]

Re-opened so we can follow up with the recomendation.

othercorey avatar Feb 19 '24 07:02 othercorey