Andrew Kaster
Andrew Kaster
No, I should have just pushed to a separate branch in my fork and said "pull these in pls"
It linked just fine on my machine. Let's figure out why instead of linking AK to LibTest
If AK for normal executables has the custom assertion handler in it, then we've failed at making the custom assertion handler test-only
Sure, check discord. I posted my compiler/linker version as well.
The correct change here is to setup proper export macros for all the libraries. This isn't the only such linker error. We've discussed it in #ui-windows on discord. If you...
...huh. Does Windows have an implicit `include_directories(${CMAKE_CURRENT_BINARY_DIR})` or something? I fixed this up to move the macro to lagom_lib and edited the commit messages a bit, but it doesn't compile...
> /home/runner/work/ladybird/ladybird/AK/StdLibExtraDetails.h:148:43: error: blocks support disabled - compile with -fblocks or pick a deployment target that supports them 148 | inline constexpr bool IsBlockClosure = true; Oh great. Are we...
Oh and GCC doesn't support blocks at all, let alone ARC. So I guess adopting this patch would need some serious ifdef surgery to pretend blocks don't exist on gcc,...
Without commenting on the technical points of this issue, the correct capitalization is "Ladybird", as in "Ladybug" 🐞, not "LadyBird" as in female bird 🐦
Hi, thanks for your interest in the project and the patch! However, the Android build is currently broken. It does not build all of its vcpkg dependencies, and the build...