Andrew Kaster
Andrew Kaster
When CMake invokes vcpkg, it installs all of the dependencies to a custom prefix under the current `CMAKE_BINARY_DIR`. Why do you want to provide your own? If you want to...
I saw on your AppImage repository that you were asking why we are using bleeding edge, almost-trunk dependencies for most of the libraries we're using? The rationale is quite simple:...
@linsmod You're looking at the wrong docs. there's android build docs. However, the android build is broken. we'll fix it eventually. I have a stale PR that made the dependencies...
4860 is this pull request. Issues and pull requests are essentially the same thing in GitHub's backend, just with a different "type". Confusing and counterintuitive, but it's always been that...
@rcorsi the final state of your PR looks reasonable. However like I mentioned, our PR merge workflow ends up cherry-picking PR commits directly onto master. That means all commits in...
@Xazax-hun I added your example to one of my header files like so: ```c++ namespace AK { template To cxxCast(From i) { return static_cast(i); } } ``` And the compiler...
This repository better reproduces the issue with the suggested workaround https://github.com/ADKaster/swift-base-class-unsafe-unretained/ Reproduce by running ./build.sh It might need some tweaking to play nice on macOS (remove the jq-based include?) I...
Apparently the issue is that the cxxCast template was added inside a namespace? I guess I can put it in the global namespace for now as a workaround for the...
Also would be nice to split the AK and LibTest+Tests parts into separate commits. Feel free to use your name + email instead of the generic "The Ladybird Developers" btw.
your latest push overrode the changes from https://github.com/LadybirdBrowser/ladybird/commit/38714fd93765a1789b966c93e975ef34c688f4b4. I s'pose that's why two people working on the same branch is not recommended for a rebase workflow :sweat_smile: