Andrew Kaster

Results 509 comments of Andrew Kaster

I suspect that building the oss-fuzz images via the instructions in will fail after this commit. Can you verify? We can't bump our minimum required clang version until they update...

Conflicts with DeprecatedString --> ByteString change

I believe https://github.com/SerenityOS/serenity/pull/22671 should have fixed the issue this PR is trying to solve. Feel free to re-open and/or comment on the issue if it's still present.

This comes from an `asm(".incbin \"LibCompress/BrotliDictionaryData.bin\"\n" ` in Userland/Libraries/LibCompress/BrotliDictionary.cpp I'm not sure what the rules are for how the assembler searches for binary files. It looks like your RPM build...

Hmm that's here That shouldn't(?) be possible unless we ended up corrupting the socket data stream somehow. Should be straightforward to printf debug by dumping the raw message bytes after...

You need to also provide the version.txt file. See this WIP branch on my fork with a flatpak build, and my PR to nixpkgs that kept failing on x86_64 macOS...

Is an offline build really that common a need for developers? At the moment we are much more focused on developer experience than packager experience, especially since we don't feel...

Sorry for taking so long on this! I like this change. After testing it, I found a simple crash in GMLPlayground with invalid or in-progress property values. For example: ```...

> be able to start a refactor that remove libc dependency from our libraries when they run on SerenityOS; I don't really agree that this is a goal. What's the...

> So LibFont needs to depend on LibMedia, which depends on LibGfx LibGfx/Font was created by merging LibTTF with LibGfx to remove a cyclic dependency. What is the indented layering...