Andrew Kaster

dear god clang-format hates everything about these changes. I guess I was supposed to clang-format *after* the rebase? edit: no, just doing a `cp /.clang-format .` before running the format.sh...

Looks like this is failing on license headers. So I'll either need to add a commit to add them all at the end, or figure out a magic `git filter-branch`...

Alternatively, I could squash all of this into one mega-commit, and apply a ton of changes before merge 🤔

This is a stack overflow in hit testing ``` Thread 1 "WebContent" received signal SIGSEGV, Segmentation fault. 0x00007fd4c6df991d in hit_test () at /home/andrew/serenity/Userland/Libraries/LibWeb/Painting/PaintableBox.cpp:783 783 if (layout_box().is_viewport()) { (gdb) bt #0...

I'm... assuming that this is a result of your RPM build stripping RPATH from our binaries? We build C++ applications as code generators into Build/bin and expect them to be...

Ah right, this happens here in lagom_install_options.cmake: https://github.com/SerenityOS/serenity/blob/e28ac74e0b65334c92e0ba569dfa3a6ff9ece0cf/Meta/CMake/lagom_install_options.cmake#L11-L28 The intention is that we can prevent the need to patch up RPATH or macOS equivalents (@rpath, @executable_path, etc) when executing out...

@david072 I rebased this and fixed the conflicts, and I'll merge once it passes CI. I did find a couple boogs that I'll open as issues though.

Stalebot pls

> Importing upstream as one commit seems alright, but maybe changes from upstream should be in separate commits? That's a good point. I'll re-apply my changes from upstream on top...

I'll close this for now, perhaps there is a path to a GTK chrome some time in the future.