serenity icon indicating copy to clipboard operation
serenity copied to clipboard

AK/Kernel: Remove unneeded code due to P0960R3 now being in Clang-16

Open stelar7 opened this issue 1 year ago • 5 comments

stelar7 avatar Dec 12 '23 14:12 stelar7

Note: According to https://en.cppreference.com/w/cpp/compiler_support since clang16

Might be good to mention the clang version in the commit

Hendiadyoin1 avatar Dec 12 '23 15:12 Hendiadyoin1

I suspect that building the oss-fuzz images via the instructions in https://github.com/SerenityOS/serenity/tree/master/Meta/Lagom#fuzzing-on-oss-fuzz will fail after this commit. Can you verify? We can't bump our minimum required clang version until they update their platform, or we go into our docker file in the oss-fuzz repo and add our own clang version for the fuzzers to use.

ADKaster avatar Dec 19 '23 23:12 ADKaster

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jan 10 '24 00:01 stale[bot]

I suspect that building the oss-fuzz images via the instructions in master/Meta/Lagom#fuzzing-on-oss-fuzz will fail after this commit. Can you verify? We can't bump our minimum required clang version until they update their platform, or we go into our docker file in the oss-fuzz repo and add our own clang version for the fuzzers to use.

I tried to build the images, but couldnt get it to work. :/

stelar7 avatar Jan 12 '24 07:01 stelar7

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Feb 04 '24 23:02 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar Feb 13 '24 05:02 stale[bot]