Andrew Kaster
Andrew Kaster
Updates since last reviewed: - formatted all files with `gn format` - default to symbol_level=1 - removed library_name.gni and set `liblagom-` prefix in toolchain/BUILD.gn - documented args - removed unnecessary...
Updates since last: - Fixed up build so that it works on Ubuntu 22.04 with gn args as below ``` host_cc = "clang" host_cxx = "clang++" is_clang = true use_lld...
The consteval change broke oss-fuzz :( I opened a fix.
I think this change set is fine, but needs a rebase -- the commits are pretty old :)
@supercomputer7 I reverted the last two commits in https://github.com/SerenityOS/serenity/pull/22497 as the main commit of the PR breaks shift and caps lock from using with the default QEMU settings. Please take...
> I did not add tests, because the path currently is only taken in aarch64-serenity builds I would rather the tests exist in the tree with a screenshot of running...
This looks good to go from me, but it ran into a change Andreas made in LibCore. I'll push up a rebase and then merge it. Thanks for sticking through...
Hmm Seems I was wrong, the issue was that the `REGISTER_WIDGET` declaration needed to specify `REGISTER_WIDGET(::Calendar, EventCalendar);`, because the compilers select GUI::Calendar as the entity you're referring to over the...
One comment before looking at this, according to the public suffix list, it seems they would rather we only pull it "once per day" to avoid load on their servers....
This is not the correct fix for the referenced issue. The line that crashes in #19017 is this: ``` auto stderr_stream = Core::File::standard_error().release_value_but_fixme_should_propagate_errors(); ``` This is very much a FIXME...