Fred Silberberg comments

Results 412 comments of


                                            Fred Silberberg

Fix line breaks between members when a property has an initializer

We generally don't treat syntax normalizer's output as a public API. This may be a common change, but a generator author isn't going to observe it until they update their...

Fix line breaks between members when a property has an initializer

What impact does this PR have on non-auto properties? Will they be grouped in the same way? Consider adding some tests with expression-bodied and full-bodied properties.

Support MemberNotNull on required members in nullable analysis

@dotnet/roslyn-compiler @RikkiGibson for review.

Support MemberNotNull on required members in nullable analysis

@RikkiGibson @dotnet/roslyn-compiler for reviews please.

Reduce ImmutableDictionary allocations under SolutionCompilationState by using ImmutableSegmentedDictionary

@ToddGrun let's keep it out; I'd ask you to depend on `TryGetNonEnumeratedCount` on the appropriate TFMs anyways, so it's not like it would be an immediate no-feedback approval anyways.

Add an API to discover if a symbol is a WellKnownType that effects public API behavior

@ericstj is this something that you still want since the namespace idea?

[API Proposal]: Breaking change - Make some types static

Note, our next API review session isn't until Jan 5th (much of the office is out for US holidays), so it'll be a bit before we get to this.

[API Proposal]: Breaking change - Make some types static

### API Review * First two are already static on the C# side, seems ok * Third has similar examples on other option holder types. *Conclusion*: Approved.

Enable CA1052 (static holder types should be static)

I guess I'm not convinced of the need to break those users.

Enable CA1052 (static holder types should be static)

I guess I'm ok having that discussion. @Youssef1313, can you please open an issue?