Fred Silberberg

Results 412 comments of Fred Silberberg

You're using the old mono launch scripts to launch OmniSharp. Those are, of course, going to be using mono. OmniSharp can (and really, should) be launched using the modern .NET...

> How would I go about moving to the .NET 6 version? Don't invoke `mono` (as that script is doing). You need to call `dotnet /path/to/omnisharp.dll`.

> I want to be clear that that script is something that ships with omnisharp and that it's not something I'm doing intentionally. I'm aware of this. The script is...

In action: ![InlineValues](https://user-images.githubusercontent.com/2371880/119245029-c3077b00-bb2a-11eb-8358-fa3199159ab0.gif)

Currently, I return references on every line they occur. It might be a better design to only return the first instance of the reference that occurs inside the current viewport,...

@JoeRobich did you have any opinions on the design question around how many things to return?

Note: I still need to write some tests, which is why this is draft for the moment.

> have you thought about building this as a plugin (like Razor does)? > it sounds like a perfect candidate for a plugin, because it is a specialized type of...

Alright, I think it would be possible with some commands exposed from the vscode plugin. Here's what I'm thinking: * `omnisharp.installPlugin` - takes a string dll path and a version...

> If O# enabled plugins to provide [workspace commands](https://microsoft.github.io/language-server-protocol/specification#workspace_executeCommand) it wouldn't require exposing a new endpoint but instead would just require O# to route to specific command holders. I doubt...