Fred Silberberg
Fred Silberberg
> Is there a specific GitHub issue that this PR is trying to address? It was in response to a feedback tweet, not to a filed bug.
@AlekseyTs @jcouv I reverted Binder_Extensions.cs to before this PR, then did the suggested splitting of the condition inside the existing check. I'm going to follow up with a simplification of...
@E021ntox this is not the appropriate issue to discuss. Go the original issue if you want to talk about it.
We could certainly make this smarter, but it's not going to be trivial due to how we do (or don't do, in this case) constant folding when the entire string...
We'd review a pr that implements this (likely would be a change in how the local rewriter lowers these), but are unlikely to prioritize it ourselves.
Oh, and one more detail before I forget: AppendFormatted calls can have other important side-effects, like CallerExpression attributes, or being used for logging (where the fact that this is a...
> If allowing those CallerX attributes is so important, why isn't the constant+nameof one lowered to a single AppendLiteral call instead of AppendLiteral("abc ") / AppendX("Test")? We didn't feel that...
These questions are all spelled out in the interpolated strings draft spec. When the string is a constant, we always prefer overloads that take strings. When the string is not...
@svick, are you still interested in this PR?
@misiek08 we'd likely consider a follow up here from someone, but it would be fairly low on our review list.